Require per-state scenario sheet ID for YAML generation - #486
Merged
Conversation
MD uses a separate Runs & Charts spreadsheet from NY/RI; source SCENARIO_SHEET_ID from state.env instead of a hardcoded default. Co-authored-by: Cursor <cursoragent@cursor.com>
alxsmith
force-pushed
the
482-review-rdp-run-sheet-and-naming-conventions
branch
from
July 21, 2026 15:45
e323c4d to
8d3e979
Compare
Require utility on every data row, drop utility forward-fill and deprecated tariff path rewrites, and read run_includes_supply only (no add_supply_revenue_requirement alias). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCENARIO_SHEET_IDfrom each state'sstate.envintocreate_scenario_yamlsso MD can use its own Runs & Charts sheet while NY/RI keep the existing workbook; remove the hardcoded default sheet ID.md/config/scenarios/scenarios_bge.yamlfrom the MD sheet (includesresidual_allocation_*on subclass runs).utilityon every data row (no forward-fill), pass tariff paths through unchanged (no_elec_heat_seasonal_epmcrewrite), and requirerun_includes_supplyonly (drop legacyadd_supply_revenue_requirementalias).Closes #482
Reviewer focus
utilityfilled on every run row (merged cells will now fail fast).*_elec_heat_seasonal*, not*_epmc*).Test plan
tests/test_create_scenario_yamls.py(23 tests)just s md create-scenario-yamlsopens the MD sheet and refreshesscenarios_bge.yamljust s ny create-scenario-yamls/just s ri create-scenario-yamlsstill use the shared NY/RI sheet--sheet-idnorSCENARIO_SHEET_IDfails with a clear error